From: Jeff King Date: Thu, 30 May 2024 06:39:56 GMT Subject: [PATCH 2/5] t-strvec: mark variable-arg helper with LAST_ARG_MUST_BE_NULL Message-ID: <20240530063956.GB1949704@coredump.intra.peff.net> In-Reply-To: <20240530063857.GA1942535@coredump.intra.peff.net> This will let the compiler catch a problem like: /* oops, we forgot the NULL */ check_strvec(&vec, "foo"); rather than triggering undefined behavior at runtime. Signed-off-by: Jeff King --- t/unit-tests/t-strvec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/t/unit-tests/t-strvec.c b/t/unit-tests/t-strvec.c index 6c1465ee61..d4615ab06d 100644 --- a/t/unit-tests/t-strvec.c +++ b/t/unit-tests/t-strvec.c @@ -4,6 +4,7 @@ #define check_strvec(vec, ...) \ check_strvec_loc(TEST_LOCATION(), vec, __VA_ARGS__) +LAST_ARG_MUST_BE_NULL static void check_strvec_loc(const char *loc, struct strvec *vec, ...) { va_list ap; -- 2.45.1.692.gbe047d9c60