From: Jeff King <peff@peff.net>
Date: Sat, 25 May 2024 03:25:34 GMT
Subject: Re: [PATCH v4 19/24] t/test-lib-functions.sh: support `--notick` in `test_commit_bulk()`
Message-ID: <20240525032534.GB1890223@coredump.intra.peff.net>
In-Reply-To: <936f6d1b7e392367bb87a755d014633d7171f0ab.1716499565.git.me@ttaylorr.com>

On Thu, May 23, 2024 at 05:27:08PM -0400, Taylor Blau wrote:

> One of the tests we'll want to add for pseudo-merge bitmaps needs to be
> able to generate a large number of commits at a specific date.
> 
> Support the `--notick` option (with identical semantics to the
> `--notick` option for `test_commit()`) within `test_commit_bulk` as a
> prerequisite for that. Callers can then set the various _DATE variables
> themselves.

Looks good. I expected to see you add "--date" _also_, but it looks like
you just set $GIT_COMMITTER_DATE yourself. Which I think is fine for our
purposes here.

-Peff