From: Jeff King Date: Fri, 03 May 2024 17:48:41 GMT Subject: Re: [PATCH v2 0/3] color: add support for 12-bit RGB colors Message-ID: <20240503174841.GF3631237@coredump.intra.peff.net> In-Reply-To: <20240502110331.6347-1-dev+git@drbeat.li> On Thu, May 02, 2024 at 01:03:28PM +0200, Beat Bolli wrote: > * The color parsing code learned to handle 12-bit RGB colors. > > The first commit fixes a typo, the second one adds some test coverage > for invalid RGB colors, and the final one extends the RGB color parser > to recognize 12-bit colors, as in #f0f. > --- > > Changes against v1: > - add test coverage for invalid RGB color lengths Ah, I missed that you had sent a new version when I responded to Junio. Yeah, this whole thing looks good to me! -Peff