From: Jeff King <peff@peff.net>
Date: Wed, 06 Mar 2024 00:50:57 GMT
Subject: Re: [PATCH 1/2] ci: also define CXX environment variable
Message-ID: <20240306005057.GC3797463@coredump.intra.peff.net>
In-Reply-To: <75f98cbf98005b0a069977096ec5501f2f7830fe.1709673020.git.steadmon@google.com>

On Tue, Mar 05, 2024 at 01:11:59PM -0800, Josh Steadmon wrote:

> In a future commit, we will build the fuzzer executables as part of the
> default 'make all' target, which requires a C++ compiler. If we do not
> explicitly set CXX, it defaults to g++ on GitHub CI. However, this can
> lead to incorrect feature detection when CC=clang, since the
> 'detect-compiler' script only looks at CC. Fix the issue by always
> setting CXX to match CC in our CI config.
> 
> We only plan on building fuzzers on Linux, so none of the other CI
> configs need a similar adjustment.

Does this mean that after your patch 2, running:

  make CC=clang

may have problems on Linux, because it will now try to link fuzzers
using g++, even though everything else is built with clang (and ditto
the detect-compiler used it)?

-Peff