From: Jeff King <peff@peff.net>
Date: Fri, 01 Mar 2024 06:58:05 GMT
Subject: Re: [PATCH v4 03/11] commit-reach(repo_in_merge_bases_many): report missing commits
Message-ID: <20240301065805.GB2680308@coredump.intra.peff.net>
In-Reply-To: <1938b317a49f4d688bfefd7e5a74ad750a55a91a.1709113458.git.gitgitgadget@gmail.com>

On Wed, Feb 28, 2024 at 09:44:09AM +0000, Johannes Schindelin via GitGitGadget wrote:

> @@ -1402,6 +1436,8 @@ static int merge_mode_and_contents(struct merge_options *opt,
>  							&o->oid,
>  							&a->oid,
>  							&b->oid);
> +			if (result->clean < 0)
> +				return -1;

Sorry, I accidentally commented on v2 of your series a moment ago,
rather than the most recent version. But this hunk was untouched between
the two, so the comment still applies:

  https://lore.kernel.org/git/20240301065647.GA2680308@coredump.intra.peff.net/

-Peff