From: René Scharfe Date: Sat, 24 Feb 2024 21:29:49 GMT Subject: [PATCH 2/6] parse-options: set arg of abbreviated option lazily Message-ID: <20240224212953.44026-3-l.s.r@web.de> In-Reply-To: <20240224212953.44026-1-l.s.r@web.de> Postpone setting the opt pointer until we're about to call get_value(), which uses it. There's no point in setting it eagerly for every abbreviated candidate option, which may turn out to be ambiguous. Removing this assignment from the loop doesn't noticeably improve the performance, but allows further simplification. --- parse-options.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/parse-options.c b/parse-options.c index e4ce33ea48..056c6b30e9 100644 --- a/parse-options.c +++ b/parse-options.c @@ -391,8 +391,6 @@ static enum parse_opt_result parse_long_opt( ambiguous_option = abbrev_option; ambiguous_flags = abbrev_flags; } - if (*arg_end) - p->opt = arg_end + 1; abbrev_option = options; abbrev_flags = flags ^ opt_flags; continue; @@ -441,8 +439,11 @@ static enum parse_opt_result parse_long_opt( abbrev_option->long_name); return PARSE_OPT_HELP; } - if (abbrev_option) + if (abbrev_option) { + if (*arg_end) + p->opt = arg_end + 1; return get_value(p, abbrev_option, abbrev_flags); + } return PARSE_OPT_UNKNOWN; } -- 2.44.0