From: Mike Hommey <mh@glandium.org>
Date: Sat, 24 Feb 2024 05:10:40 GMT
Subject: Re: [ANNOUNCE] Git v2.44.0
Message-ID: <20240224051040.ftuo24smozqugbde@glandium.org>
In-Reply-To: <xmqqbk87w164.fsf@gitster.g>

Hi,

On Fri, Feb 23, 2024 at 09:17:07AM -0800, Junio C Hamano wrote:
> Patrick Steinhardt (139):
>       builtin/clone: create the refdb with the correct object format

I haven't analyzed how/why exactly yet, but I've bisected a regression
in the behavior of is_git_directory() during a clone to originate from
this change.

Here's a way to reproduce the problem:

```
$ cat > git-remote-foo <<EOF
#!/bin/sh
git config --local -l >&2
exit 1
EOF
$ chmod +x git-remote-foo
$ PATH=$PWD:$PATH git clone foo::bar
```

With versions < 2.44.0, it displays the local configuration, e.g.:
```
core.repositoryformatversion=0
core.filemode=true
core.bare=false
core.logallrefupdates=true
remote.origin.url=foo::bar
```

but with 2.44.0, it fails with:
```
fatal: --local can only be used inside a git repository
```

Mike