From: Jeff King <peff@peff.net>
Date: Fri, 10 Nov 2023 21:46:40 GMT
Subject: Re: [PATCH v2 0/4] Replace use of `test <expr> -o/a <expr>`
Message-ID: <20231110214640.GD2758295@coredump.intra.peff.net>
In-Reply-To: <cover.1699609940.git.ps@pks.im>

On Fri, Nov 10, 2023 at 11:01:11AM +0100, Patrick Steinhardt wrote:

> this is the second version of my patch series that replaces all uses of
> `test <expr> -o/a <expr`.
> 
> Changes compared to v1:
> 
>     - I've expanded a bit on why we want to do these conversions in the
>       first place in the first commit message.
> 
>     - Dropped a needless subshell and added missing quoting while at it.
> 
>     - Explained why we need to decompose the asserts in the second patch
>       into two asserts.

These look OK to me. I mentioned a small nit on the first patch, but I
am OK with ignoring it (and we are reaching diminishing returns
polishing an otherwise trivial series).

-Peff