From: Jonathan Tan <jonathantanmy@google.com>
Date: Tue, 31 Oct 2023 22:24:00 GMT
Subject: Re: [RFC PATCH 2/3] strbuf_commented_addf(): drop the comment_line_char parameter
Message-ID: <20231031222400.2048688-1-jonathantanmy@google.com>
In-Reply-To: <xmqqh6m74bdo.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:
> This moving of the helper function does not belong to the "fix
> commented_addf() not to take the comment_line_char" step.
> 
> The series should be restructured to have the two patches from me
> first, and then your moving some stuff to environment.c, probably.

This means that #include "environment.h" will be added and then removed
in the same series, but I don't feel too strongly about that. I'll send
an updated set of patches.