From: Jonathan Tan Date: Mon, 23 Oct 2023 18:53:07 GMT Subject: Re: [PATCH v3 5/5] config-parse: split library out of config.[c|h] Message-ID: <20231023185307.996813-1-jonathantanmy@google.com> In-Reply-To: Josh Steadmon writes: > From: Glen Choo > > The config parsing machinery (besides "include" directives) is usable by > programs other than Git - it works with any file written in Git config > syntax (IOW it doesn't rely on 'core' Git features like a repository), > and as of the series ending at 6e8e7981eb (config: pass source to > config_parser_event_fn_t, 2023-06-28), it no longer relies on global > state. Thus, we can and should start turning it into a library other > programs can use. Checking this with --color-moved looks good, but we'll need to take another look once my comments about the earlier patches have been addressed.