From: Jeff King <peff@peff.net>
Date: Fri, 06 Oct 2023 00:51:32 GMT
Subject: Re: [PATCH 2/3] revision: clear decoration structs during release_revisions()
Message-ID: <20231006005132.GA992085@coredump.intra.peff.net>
In-Reply-To: <xmqq34yoekt5.fsf@gitster.g>

On Thu, Oct 05, 2023 at 04:00:54PM -0700, Junio C Hamano wrote:

> Wow, nested maze of callbacks make my head spin ;-) but they all
> look reasonable.  Thanks.

Yeah, I don't love those one-liner callbacks just to handle the cast.

The other alternative is to write some kind of for_each_decoration()
macro, but I think it ends up in the usual macro hell (requiring the
caller to provide iterator variables, hanging half-open braces, and so
on). It might be worth it if iterating could be used in other places,
but I don't think it is.

So I tried to choose the lesser of two evils. :)

-Peff