From: Jeff King Date: Sat, 16 Sep 2023 05:32:57 GMT Subject: Re: [PATCH 2/2] test-lib: fix GIT_TEST_SANITIZE_LEAK_LOG Message-ID: <20230916053257.GC13092@coredump.intra.peff.net> In-Reply-To: On Fri, Sep 15, 2023 at 10:51:17AM -0700, Junio C Hamano wrote: > Jeff King writes: > > > But having done so, the main value in re-rolling would be preventing > > somebody else from reading the code and having the same question. > > Indeed. It would be valuable to help future developers not to waste > time on wondering what we already know they may do so on. I guess I was thinking "maybe that is not a good reason to change what the code does" when I wrote my other email. But it is probably a good reason to make a note in the commit message. :) -Peff