From: Jonathan Tan <jonathantanmy@google.com>
Date: Mon, 14 Aug 2023 22:28:23 GMT
Subject: Re: [RFC PATCH v2 7/7] git-std-lib: add test file to call git-std-lib.a functions
Message-ID: <20230814222823.65107-1-jonathantanmy@google.com>
In-Reply-To: <20230810163654.275023-7-calvinwan@google.com>

Calvin Wan <calvinwan@google.com> writes:
> Add test file that directly or indirectly calls all functions defined in
> git-std-lib.a object files to showcase that they do not reference
> missing objects and that git-std-lib.a can stand on its own.
> 
> Certain functions that cause the program to exit or are already called
> by other functions are commented out.
> 
> TODO: replace with unit tests
> Signed-off-by: Calvin Wan <calvinwan@google.com>

Thanks for this patch - it's useful for reviewers to see what this
patch set accomplishes (a way to compile a subset of files in Git that
can provide library functionality). I don't think we should merge it
as-is but should wait until we have a unit test that also exercises
functions, and then merge that instead (I think your TODO expresses the
same sentiment).