From: Jonathan Tan Date: Mon, 14 Aug 2023 22:15:14 GMT Subject: Re: [RFC PATCH v2 4/7] parse: create new library for parsing strings and env values Message-ID: <20230814221514.62111-1-jonathantanmy@google.com> In-Reply-To: Glen Choo writes: > But, I don't see a why a non-Git caller would want environment value > parsing in git-std-lib. I wouldn't think that libraries should be > reading Git-formatted environment variables. I think environment parsing in git-std-lib is fine, at least for the short term. First, currently we expect a lot from a user of our library (including tolerating breaking changes in API), so I think it is reasonable for such a user to be aware that some functionality can be changed by an environment variable. Second, the purpose of the library is to provide functionality that currently is only accessible through CLI in library form, and if the CLI deems that some functionality should be accessible through an environment variable instead of a config variable or CLI parameter for whatever reason, we should reflect that in the library as well.