From: Jonathan Tan <jonathantanmy@google.com>
Date: Fri, 11 Aug 2023 22:15:41 GMT
Subject: Re: leak in jt/path-filter-fix, was Re: What's cooking in git.git (Aug 2023, #01; Wed, 2)
Message-ID: <20230811221541.3332720-1-jonathantanmy@google.com>
In-Reply-To: <ZNKj9vwZv4kKJEcL@nand.local>

Taylor Blau <me@ttaylorr.com> writes:
> On Tue, Aug 08, 2023 at 03:22:40PM -0400, Jeff King wrote:
> > Since this hit 'next', Coverity complained about a small leak. Fixed by
> > the patch below.
> 
> The patch below looks good and makes sense to me. That warning is
> awfully long, though ;-).
> 
> In any event, I expect that 'next' will be rewound before this topic
> graduates, since it is meaty and we are in the middle of the -rc phase.
> 
> ...and we also have my series on top [1], so it may be worthwhile for
> you, Jonathan, and I to figure out how to combine our efforts here. I
> think that this could likely get squashed in to Jonathan's topic
> if/after it gets ejected from 'next'. We can take my patches together in
> the same series, separately in a different one, or discard them
> altogether.
> 
> If we do decide to pursue the approach in [1], I think combining
> everything together into one big series makes the most sense for ease of
> merging.
> 
> [1]: https://lore.kernel.org/git/ZMv14grkM7x7Sf8m@nand.local/
> 
> Thanks,
> Taylor

For what it's worth, whatever we decide sounds good to me.