From: Jeff King Date: Tue, 08 Aug 2023 21:28:52 GMT Subject: Re: [PATCH] describe: fix --no-exact-match Message-ID: <20230808212852.GA760815@coredump.intra.peff.net> In-Reply-To: <20230808212720.GA760752@coredump.intra.peff.net> On Tue, Aug 08, 2023 at 05:27:21PM -0400, Jeff King wrote: > So before I sent a patch (either to switch to using opt->value, or to > add an UNUSED annotation), I wanted to see what you (or others) thought > between the two. I.e., should we have a rule of "try not to operate on > global data via option callbacks" or is that just being too pedantic for > one-off callbacks like this? Oh, and btw, the same situation exists for the "pack-objects --no-quiet" earlier in this thread (which is why I was trying to establish the general approach). -Peff