From: Jonathan Tan Date: Thu, 20 Jul 2023 20:22:03 GMT Subject: Re: [PATCH 0/4] commit-graph: avoid looking at Bloom filter data directly Message-ID: <20230720202203.3816309-1-jonathantanmy@google.com> In-Reply-To: Taylor Blau writes: > Hi Jonathan, > > Here's a few commits (and one fixup!) that could go before the second > patch of your series, with the fixup! getting squashed into the second > patch itself. > > The first three are preparatory, but the fourth patch should allow us to > drop the Perl hackery necessary to dump the raw contents of arbitrary > Bloom filters. > > Feel free to pick up these patches (or not), just wanted to get these > out there as a possible suggestion. Ah, thanks! I'm on the fence myself about whether this really needs to be more rigorous (the Perl part just gives us an offset; we still check that what's at the offset is correct) but since you have written the patches already, I'll just include them.