From: Jonathan Tan Date: Wed, 28 Jun 2023 22:23:26 GMT Subject: Re: [PATCH v5 00/11] config: remove global state from config iteration Message-ID: <20230628222326.116535-1-jonathantanmy@google.com> In-Reply-To: "Glen Choo via GitGitGadget" writes: > As promised, this version addresses the comments on v3. > > = Changes since v4 > > - Squash 6-7/12 since `test_must_fail` doesn't catch BUG() > - Move a hunk to later in the series where it belongs > - Replace a memcpy with `*a = *b` > > = Changes since v3 > > - Rebase onto newer 'master' > - Move the 'remove UNUSED from tr2_cfg_cb' hunk from 9/12 -> 8/12. It should > have been there all along; v3 8/12 didn't build at all. Looks like all my comments have been addressed, so this patch set looks good to me.