From: Jonathan Tan <jonathantanmy@google.com>
Date: Fri, 23 Jun 2023 20:32:19 GMT
Subject: Re: [PATCH v3 06/12] builtin/config.c: test misuse of format_config()
Message-ID: <20230623203219.3255267-1-jonathantanmy@google.com>
In-Reply-To: <a2a891a069f46d3d77cafe61f64402c93cffaae4.1687290233.git.gitgitgadget@gmail.com>

"Glen Choo via GitGitGadget" <gitgitgadget@gmail.com> writes:
> +test_expect_success '--show-origin with --default' '
> +	test_must_fail git config --show-origin --default foo some.key
> +'

On my machine, this fails with

  BUG: config.c:4035: current_config_origin_type called outside config callback
  /usr/local/google/home/jonathantanmy/git/t/test-lib-functions.sh: line 1067: 3255109 Aborted                 "$@" 2>&7
  test_must_fail: died by signal 6: git config --show-origin --default foo some.key

(So it indeed fails, as expected, but test_must_fail seems to not like
the exit code.)

Not sure if we need to be more precise with the exit code we're testing
for.