From: Jeff King Date: Mon, 12 Jun 2023 04:06:51 GMT Subject: Re: tests: mark as passing with SANITIZE=leak Message-ID: <20230612040651.GK306352@coredump.intra.peff.net> In-Reply-To: <9eb931e7-dd18-8ce8-4d4a-cf3d85066189@gmail.com> On Sun, Jun 11, 2023 at 08:29:09PM +0200, Rubén Justo wrote: > Each of the commits (except 11/11) fixes a leak. They have no > dependencies on each other. As a result, they can be reordered. Thanks for a pleasant read. I think each case is correct, though I left a few minor comments. Some of them are things I think are worth including in a re-roll. Others are things that we _could_ go further to refactor for clarity, but I am OK if you want to stay focused on the minimal leak-fixes. -Peff