From: Jonathan Tan <jonathantanmy@google.com>
Date: Fri, 02 Jun 2023 00:06:15 GMT
Subject: Re: [PATCH v2 13/14] config: add kvi.path, use it to evaluate includes
Message-ID: <20230602000615.434180-1-jonathantanmy@google.com>
In-Reply-To: <7d9b9eefc7860959dbb6ed86d8c3d165a978a0b5.1685472134.git.gitgitgadget@gmail.com>

"Glen Choo via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Glen Choo <chooglen@google.com>
> 
> Include directives are evaluated using the path of the config file. To
> reduce the dependence on "config_reader.source", add a new
> "key_value_info.path" member and use that instead of
> "config_source.path".

Maybe add:

  This allows us to remove a "struct config_reader *" field from "struct
  config_include_data", which will subsequently allow us to remove "struct
  config_reader" entirely.
   
The code change looks good.