From: Jeff King <peff@peff.net>
Date: Fri, 19 May 2023 00:13:55 GMT
Subject: Re: [PATCH 2/9] fetch: drop unneeded NULL-check for `remote_ref`
Message-ID: <20230519001355.GB2442034@coredump.intra.peff.net>
In-Reply-To: <7197540df60d34e8f727e29d300dd0c96e31d310.1684324059.git.ps@pks.im>

On Wed, May 17, 2023 at 01:48:46PM +0200, Patrick Steinhardt wrote:

> Drop the `NULL` check for `remote_ref` in `update_local_ref()`. The
> function only has a single caller, and that caller always passes in a
> non-`NULL` value.
> 
> This fixes a false positive in Coverity.

Thanks for following up on this. I was thinking of just reposting it,
thinking there weren't that many other cleanups to do in fetch.c. But
you found quite a few. :)

The patch looks obviously good to me.

-Peff