From: Jonathan Tan Date: Tue, 16 May 2023 00:00:41 GMT Subject: Re: [PATCH v2 16/27] read-cache*.h: move declarations for read-cache.c functions from cache.h Message-ID: <20230516000041.1458613-1-jonathantanmy@google.com> In-Reply-To: <41183b7baed30ba19e98961944e946919995c2c1.1683875070.git.gitgitgadget@gmail.com> "Elijah Newren via GitGitGadget" writes: > From: Elijah Newren > > For the functions defined in read-cache.c, move their declarations from > cache.h to a new header, read-cache-ll.h. Also move some related inline > functions from cache.h to read-cache.h. The purpose of the > read-cache-ll.h/read-cache.h split is that about 70% of the sites don't > need the inline functions and the extra headers they include. Ah, the 70% is not something I would have expected, but since this is the case, the split into -ll and without makes sense. Up to here looks good.