From: Felipe Contreras Date: Sun, 12 Mar 2023 20:08:54 GMT Subject: [PATCH 3/5] perf: grep: don't check PRCE twice Message-ID: <20230312200856.323688-4-felipe.contreras@gmail.com> In-Reply-To: <20230312200856.323688-1-felipe.contreras@gmail.com> Just set the prereq and let the testing framework check it once. Cc: Ævar Arnfjörð Bjarmason Signed-off-by: Felipe Contreras --- t/perf/p4220-log-grep-engines.sh | 2 +- t/perf/p4221-log-grep-engines-fixed.sh | 2 +- t/perf/p7820-grep-engines.sh | 2 +- t/perf/p7821-grep-engines-fixed.sh | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/t/perf/p4220-log-grep-engines.sh b/t/perf/p4220-log-grep-engines.sh index 03fbfbb85d..2c619a626f 100755 --- a/t/perf/p4220-log-grep-engines.sh +++ b/t/perf/p4220-log-grep-engines.sh @@ -30,7 +30,7 @@ do # Poor man's basic -> extended converter. pattern=$(echo $pattern | sed 's/\\//g') fi - if test $engine = "perl" && ! test_have_prereq PCRE + if test $engine = "perl" then prereq="PCRE" else diff --git a/t/perf/p4221-log-grep-engines-fixed.sh b/t/perf/p4221-log-grep-engines-fixed.sh index 0a6d6dfc21..095c5d1765 100755 --- a/t/perf/p4221-log-grep-engines-fixed.sh +++ b/t/perf/p4221-log-grep-engines-fixed.sh @@ -20,7 +20,7 @@ for pattern in 'int' 'uncommon' 'æ' do for engine in fixed basic extended perl do - if test $engine = "perl" && ! test_have_prereq PCRE + if test $engine = "perl" then prereq="PCRE" else diff --git a/t/perf/p7820-grep-engines.sh b/t/perf/p7820-grep-engines.sh index 9bfb86842a..336424cb00 100755 --- a/t/perf/p7820-grep-engines.sh +++ b/t/perf/p7820-grep-engines.sh @@ -41,7 +41,7 @@ do # Poor man's basic -> extended converter. pattern=$(echo "$pattern" | sed 's/\\//g') fi - if test $engine = "perl" && ! test_have_prereq PCRE + if test $engine = "perl" then prereq="PCRE" else diff --git a/t/perf/p7821-grep-engines-fixed.sh b/t/perf/p7821-grep-engines-fixed.sh index 0d75240dae..79b1b9f8b2 100755 --- a/t/perf/p7821-grep-engines-fixed.sh +++ b/t/perf/p7821-grep-engines-fixed.sh @@ -25,7 +25,7 @@ for pattern in 'int' 'uncommon' 'æ' do for engine in fixed basic extended perl do - if test $engine = "perl" && ! test_have_prereq PCRE + if test $engine = "perl" then prereq="PCRE" else -- 2.39.2.13.g1fb56cf030