From: Calvin Wan <calvinwan@google.com>
Date: Thu, 02 Mar 2023 18:02:00 GMT
Subject: Re: [PATCH v5 2/3] rebase: deprecate --rebase-merges=""
Message-ID: <20230302180200.2698729-1-calvinwan@google.com>
In-Reply-To: <20230225180325.796624-3-alexhenrie24@gmail.com>

> -			; /* default mode; do nothing */
> +			warning(_("--rebase-merges with an empty string "
> +				  "argument is deprecated and will stop "
> +				  "working in a future version of Git. Use "
> +				  "--rebase-merges=no-rebase-cousins "
> +				  "instead."));

Just a small nit on the warning message. It should describe to the user
what behavior is happening here and presumably the user wanted
`--rebase-merges` with no argument. For example, "Defaulting to
--rebase-merges instead."