From: John Cai <johncai86@gmail.com>
Date: Thu, 16 Feb 2023 20:34:50 GMT
Subject: Re: [PATCH v2 1/2] diff: consolidate diff algorithm option parsing
Message-ID: <20230216203450.yej5c5dejjz6e4r7@pop-os>
In-Reply-To: <xmqqk00itj0c.fsf@gitster.g>

On 23/02/15 06:57PM, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
> 
> > I'd have expected it with individual callbacks like:
> >
> >   int handle_patience(...)
> >   {
> > 	do_patience_specific_stuff();
> > 	do_shared_stuff(PATIENCE_DIFF);
> >   }
> >
> >   int handle_histogram(...)
> >   {
> > 	do_shared_stuff(HISTOGRAM_DIFF);
> >   }
> >
> > and so on. That's a bit more verbose, but the call stack reflects the
> > flow we expect.
> 
> Exactly.
> 
> Thanks for spelling it out.

Thanks for this suggestion--makes sense to me. Will incorporate in the next
version.