From: Calvin Wan Date: Wed, 01 Feb 2023 23:52:49 GMT Subject: Re: [PATCH 0/5] format-patch: Add --{to,cc}-cmd support Message-ID: <20230201235253.1891546-1-calvinwan@google.com> In-Reply-To: <20230119223858.29262-1-zev@bewilderbeest.net> Hi Zev! Thanks for the patch series. I agree that these flags are a very good idea to add. I appreciate the well written cover letter -- it does well describing the need for this series and calling out design questions. I'll leave the rest of my comments in the particular patches, looking forward to the reroll! > - As currently written any commands specified are only run on the > patches themselves, not on the cover letter. The slight > inconsistency with git-send-email is a bit unfortunate, but I > figure it's probably not often all that useful in that context > anyway (and the implementation looked like it would be just > non-trivial enough that laziness may have played a role as well). It is also inconsistent with git-format-patch --to and --cc. I strongly believe that your flags should also work with the cover letter, since users should expect equivalency across similar flags. git-send-email has config options, sendemail.tocmd and sendemail.cccmd, that I also believe should be implemented.