From: Teng Long Date: Wed, 01 Feb 2023 08:08:54 GMT Subject: Re: [PATCH v4 3/5] notes.c: drop unreachable code in 'append_edit()' Message-ID: <20230201080854.28231-1-tenglong.tl@alibaba-inc.com> In-Reply-To: On Mon, 30 Jan 2023 00:38:02 -0500 Eric Sunshine wrote: > It's unfortunate, perhaps, that the git-notes command-set is not > orthogonal, but it's another case of historic accretion. According to > the history, as originally implemented, git-notes only supported two > commands, "edit" and "show", and "edit" was responsible for _all_ > mutation operations, including deletion. git-notes only grew a more > complete set of commands a couple years later. > > At any rate, even though the original behaviors may not make as much > sense these days now that git-notes has a more complete set of > commands, we still need to be careful not to break existing workflows > and scripts (tooling). That's why it would be nice to beef up the > tests so that the existing behaviors don't get broken by changes such > as this patch wants to make. But, as mentioned earlier, the additional > tests probably shouldn't be part of this series, but rather can be > done as a separate series (by someone; it doesn't have to be you). Make sense by your detailed explanation. Thanks.