From: Lars Kellogg-Stedman <lars@oddbit.com>
Date: Fri, 09 Dec 2022 19:16:39 GMT
Subject: Re: [PATCH v2] line-range: Fix infinite loop bug with degenerate regex
Message-ID: <20221209191639.ixsvxgf5ef2zloik@oddbit.com>
In-Reply-To: <221207.86tu27aju3.gmgdl@evledraar.gmail.com>

On Wed, Dec 07, 2022 at 05:52:04AM +0100, Ævar Arnfjörð Bjarmason wrote:
> We really should fix this, but why not just count this as a match,
> rather than erroring out?
> 
> That we're mixing up whether '$' always matches here with our iteration
> loop is our own internal bug, we shouldn't error out on a '$'. It's just
> a regex that happens to match everything.

Thanks, that makes a lot of sense. I'll try to rework things this
weekend.

Cheers,

-- 
Lars Kellogg-Stedman <lars@oddbit.com> | larsks @ {irc,twitter,github}
http://blog.oddbit.com/                | N1LKS