From: Jacob Abel Date: Fri, 04 Nov 2022 04:11:14 GMT Subject: Re: [PATCH 3/4] worktree add: add --orphan flag Message-ID: <20221104041107.cva7yf5pdibcw3ic@phi> In-Reply-To: <221104.86o7tnzehq.gmgdl@evledraar.gmail.com> On 22/11/04 02:33AM, Ævar Arnfjörð Bjarmason wrote: > > > ... > > Here. > > > ... > > And here we have a stray style change, in this case conforming to our > CodingGuidelines (it's agnostic on the former), but IMO better to keep > this out, or split it into a "various style stuff" commit, makes this > harder to review... I believe those changes were introduced when I ran `make style`. I can revert these changes in v2. > > ... > > ditto, we don't usually \n\n split up varibale decls. Noted. Will fix in v2. > > ... > > This is just a stray refactoring of existing code to not-our-usual-style > (first arg is on the same line as the "(", rest aligned with "("). > > > ... > > Ditto, these look like they're too-long in the pre-image, but please > resist re-flowing existing code while at it. > > > ... > > ditto. Ditto the comment above regarding `make style`. > > + if (!!opts.detach + !!new_branch + !!new_branch_force + > > + !!opts.orphan_branch > > > + 1) > > The continued "if" is mis-indented, and that "1" is on a line of its > own... Ditto the comment above regarding `make style`. Also I'm not exactly sure what the tool tried to do here but I was initially hesitant to override the formatter.