From: Jonathan Tan Date: Tue, 25 Oct 2022 18:03:10 GMT Subject: Re: [PATCH v2 2/7] repo-settings: add submodule_propagate_branches Message-ID: <20221025180311.978182-1-jonathantanmy@google.com> In-Reply-To: <20499c62065d640b57bdcfd959e10b214f7e7297.1666297239.git.gitgitgadget@gmail.com> "Glen Choo via GitGitGadget" writes: > + /* > + * If the environment variable is set, assume that it came from the > + * superproject and ignore the config. > + */ Might be clearer to say: If the environment variable is set, assume that it was set by an invocation of git running in a superproject with submodule.propagateBranches set and that is recursing into this repo as a submodule. Therefore, we should ignore whatever is set in this repo's config.