From: Teng Long <dyroneteng@gmail.com>
Date: Mon, 29 Aug 2022 04:58:37 GMT
Subject: [PATCH v3 4/5] bundle-uri: add support for http(s):// and file://
Message-ID: <20220829045837.49659-1-tenglong.tl@alibaba-inc.com>
In-Reply-To: <66a1ce4045192d153d5ac66cc248ac569cac8cf6.1660050704.git.gitgitgadget@gmail.com>

Derrick Stolee <derrickstolee@github.com> writes:

> +	while (!strbuf_getline(&line, child_out)) {
> +		if (!line.len)
> +			break;
> +		if (!strcmp(line.buf, "get"))
> +			found_get = 1;
> +	}

Clear implementation for me to read, thanks.

I'm not sure but maybe a nit, should it be a "break;" after
"found_get = 1;" for omitting the left uncencerned capabilities
to quit earlier?

Thanks.