From: Jonathan Tan <jonathantanmy@google.com>
Date: Fri, 03 Jun 2022 15:27:31 GMT
Subject: Re: [PATCH v2] commit,shallow: unparse commits if grafts changed
Message-ID: <20220603152731.487338-1-jonathantanmy@google.com>
In-Reply-To: <394c054e-e1d2-41a5-a655-2ad3cb7219e0@github.com>

Derrick Stolee <derrickstolee@github.com> writes:
> This looks good. I took a quick inventory of 'struct commit' and
> agree that this is all we need. There is no need to clear the date
> or maybe_tree members. The commit_graph_data slab might have some
> information if there were no grafts before (but are now), but the
> existence of grafts should clear the commit-graph already and stop
> that slab from being used.

Thanks for taking a look.

> Grafts are only on commits. You cannot replace what a tag is pointing
> at with a graft. Replace-objects is a different thing and changes it at
> the OID level (and I don't think this can happen during the process
> without concurrent external changes to the filesystem).

Thanks for the explanation!