From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Tue, 10 May 2022 18:33:21 GMT
Subject: Re: [PATCH 2/3] t0033-safe-directory: check when 'safe.directory' is ignored
Message-ID: <20220510183321.GA4408@szeder.dev>
In-Reply-To: <b6deba3f-9019-fb6f-7bb3-cc2f647dcff6@github.com>

On Fri, Apr 29, 2022 at 03:19:01PM -0400, Derrick Stolee wrote:
> > And we do need a subshell to set the
> > config, because without unsetting GIT_TEST_ASSUME_DIFFERENT_OWNER 'git
> > config' would refuse to touch the config file.
> 
> Ah yes, of course.
>  
> > I think something like
> > 
> >   test_when_finished "(
> >         unset GIT_TEST_ASSUME_DIFFERENT_USER &&
> >         git config --unset safe.directory
> >         )"
> > 
> > would work, though.
> 
> Would it be simpler to use this?
> 
> 	GIT_TEST_ASSUME_DIFFERENT_USER=0 git config --unset safe.directory

Oh, wow.  This is so obvious, no wonder it didn't occur to me :)