From: Elia Pinto Date: Mon, 21 Mar 2022 22:54:50 GMT Subject: [PATCH 08/41] init-db.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit status Message-ID: <20220321225523.724509-9-gitter.spiros@gmail.com> In-Reply-To: <20220321225523.724509-1-gitter.spiros@gmail.com> The C standard specifies two constants, EXIT_SUCCESS and EXIT_FAILURE, that may be passed to exit() to indicate successful or unsuccessful termination, respectively. The value of status in exit(status) may be EXIT_SUCCESS, EXIT_FAILURE, or any other value, though only the least significant 8 bits (that is, status & 0377) shall be available to a waiting parent proces. So exit(-1) return 255. Use the C standard EXIT_SUCCESS and EXIT_FAILURE to indicate the program exit status instead of "0" or "1", respectively. In EXIT_FAILURE has the value "1": use EXIT_FAILURE even if the program uses exit(-1), ie 255, for consistency. Signed-off-by: Elia Pinto --- builtin/init-db.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/init-db.c b/builtin/init-db.c index 546f9c595e..d8ddc04b96 100644 --- a/builtin/init-db.c +++ b/builtin/init-db.c @@ -264,7 +264,7 @@ static int create_default_files(const char *template_path, initial_branch); if (create_symref("HEAD", ref, NULL) < 0) - exit(1); + exit(EXIT_FAILURE); free(ref); } -- 2.35.1