From: Elia Pinto Date: Mon, 21 Mar 2022 22:55:18 GMT Subject: [PATCH 36/41] test-json-writer.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit status Message-ID: <20220321225523.724509-37-gitter.spiros@gmail.com> In-Reply-To: <20220321225523.724509-1-gitter.spiros@gmail.com> The C standard specifies two constants, EXIT_SUCCESS and EXIT_FAILURE, that may be passed to exit() to indicate successful or unsuccessful termination, respectively. The value of status in exit(status) may be EXIT_SUCCESS, EXIT_FAILURE, or any other value, though only the least significant 8 bits (that is, status & 0377) shall be available to a waiting parent proces. So exit(-1) return 255. Use the C standard EXIT_SUCCESS and EXIT_FAILURE to indicate the program exit status instead of "0" or "1", respectively. In EXIT_FAILURE has the value "1": use EXIT_FAILURE even if the program uses exit(-1), ie 255, for consistency. Signed-off-by: Elia Pinto --- t/helper/test-json-writer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/helper/test-json-writer.c b/t/helper/test-json-writer.c index 37c452535f..61c5a3dac1 100644 --- a/t/helper/test-json-writer.c +++ b/t/helper/test-json-writer.c @@ -322,7 +322,7 @@ static void cmp(const char *test, const struct json_writer *jw, const char *exp) printf("error[%s]: observed '%s' expected '%s'\n", test, jw->json.buf, exp); - exit(1); + exit(EXIT_FAILURE); } #define t(v) do { make_##v(0); cmp(#v, &v, expect_##v); } while (0) -- 2.35.1