From: Elia Pinto Date: Mon, 21 Mar 2022 22:55:15 GMT Subject: [PATCH 33/41] run-command.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit status Message-ID: <20220321225523.724509-34-gitter.spiros@gmail.com> In-Reply-To: <20220321225523.724509-1-gitter.spiros@gmail.com> The C standard specifies two constants, EXIT_SUCCESS and EXIT_FAILURE, that may be passed to exit() to indicate successful or unsuccessful termination, respectively. The value of status in exit(status) may be EXIT_SUCCESS, EXIT_FAILURE, or any other value, though only the least significant 8 bits (that is, status & 0377) shall be available to a waiting parent proces. So exit(-1) return 255. Use the C standard EXIT_SUCCESS and EXIT_FAILURE to indicate the program exit status instead of "0" or "1", respectively. In EXIT_FAILURE has the value "1": use EXIT_FAILURE even if the program uses exit(-1), ie 255, for consistency. Signed-off-by: Elia Pinto --- run-command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/run-command.c b/run-command.c index a8501e38ce..5a5d865716 100644 --- a/run-command.c +++ b/run-command.c @@ -319,7 +319,7 @@ static void child_die(enum child_errcode err) /* write(2) on buf smaller than PIPE_BUF (min 512) is atomic: */ xwrite(child_notifier, &buf, sizeof(buf)); - _exit(1); + _exit(EXIT_FAILURE); } static void child_dup2(int fd, int to) -- 2.35.1