From: Elia Pinto Date: Mon, 21 Mar 2022 22:55:13 GMT Subject: [PATCH 31/41] path.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit status Message-ID: <20220321225523.724509-32-gitter.spiros@gmail.com> In-Reply-To: <20220321225523.724509-1-gitter.spiros@gmail.com> The C standard specifies two constants, EXIT_SUCCESS and EXIT_FAILURE, that may be passed to exit() to indicate successful or unsuccessful termination, respectively. The value of status in exit(status) may be EXIT_SUCCESS, EXIT_FAILURE, or any other value, though only the least significant 8 bits (that is, status & 0377) shall be available to a waiting parent proces. So exit(-1) return 255. Use the C standard EXIT_SUCCESS and EXIT_FAILURE to indicate the program exit status instead of "0" or "1", respectively. In EXIT_FAILURE has the value "1": use EXIT_FAILURE even if the program uses exit(-1), ie 255, for consistency. Signed-off-by: Elia Pinto --- path.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/path.c b/path.c index 2c895471d9..6639bab7b4 100644 --- a/path.c +++ b/path.c @@ -915,7 +915,7 @@ void safe_create_dir(const char *dir, int share) if (mkdir(dir, 0777) < 0) { if (errno != EEXIST) { perror(dir); - exit(1); + exit(EXIT_FAILURE); } } else if (share && adjust_shared_perm(dir)) -- 2.35.1