From: Elia Pinto Date: Mon, 21 Mar 2022 22:55:05 GMT Subject: [PATCH 23/41] obstack.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit status Message-ID: <20220321225523.724509-24-gitter.spiros@gmail.com> In-Reply-To: <20220321225523.724509-1-gitter.spiros@gmail.com> The C standard specifies two constants, EXIT_SUCCESS and EXIT_FAILURE, that may be passed to exit() to indicate successful or unsuccessful termination, respectively. The value of status in exit(status) may be EXIT_SUCCESS, EXIT_FAILURE, or any other value, though only the least significant 8 bits (that is, status & 0377) shall be available to a waiting parent proces. So exit(-1) return 255. Use the C standard EXIT_SUCCESS and EXIT_FAILURE to indicate the program exit status instead of "0" or "1", respectively. In EXIT_FAILURE has the value "1": use EXIT_FAILURE even if the program uses exit(-1), ie 255, for consistency. Signed-off-by: Elia Pinto --- compat/obstack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compat/obstack.c b/compat/obstack.c index 27cd5c1ea1..e8641816f7 100644 --- a/compat/obstack.c +++ b/compat/obstack.c @@ -407,7 +407,7 @@ print_and_abort (void) # else fprintf (stderr, "%s\n", _("memory exhausted")); # endif - exit (1); + exit(EXIT_FAILURE); } #endif /* !ELIDE_CODE */ -- 2.35.1