From: Elia Pinto Date: Mon, 21 Mar 2022 22:55:01 GMT Subject: [PATCH 19/41] stash.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit status Message-ID: <20220321225523.724509-20-gitter.spiros@gmail.com> In-Reply-To: <20220321225523.724509-1-gitter.spiros@gmail.com> The C standard specifies two constants, EXIT_SUCCESS and EXIT_FAILURE, that may be passed to exit() to indicate successful or unsuccessful termination, respectively. The value of status in exit(status) may be EXIT_SUCCESS, EXIT_FAILURE, or any other value, though only the least significant 8 bits (that is, status & 0377) shall be available to a waiting parent proces. So exit(-1) return 255. Use the C standard EXIT_SUCCESS and EXIT_FAILURE to indicate the program exit status instead of "0" or "1", respectively. In EXIT_FAILURE has the value "1": use EXIT_FAILURE even if the program uses exit(-1), ie 255, for consistency. Signed-off-by: Elia Pinto --- builtin/stash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/stash.c b/builtin/stash.c index 0c7b6a9588..9315ff74ce 100644 --- a/builtin/stash.c +++ b/builtin/stash.c @@ -656,7 +656,7 @@ static void assert_stash_ref(struct stash_info *info) if (!info->is_stash_ref) { error(_("'%s' is not a stash reference"), info->revision.buf); free_stash_info(info); - exit(1); + exit(EXIT_FAILURE); } } -- 2.35.1