From: Jonathan Tan <jonathantanmy@google.com>
Date: Tue, 01 Feb 2022 17:43:35 GMT
Subject: Re: [PATCH v8 0/6] implement branch --recurse-submodules
Message-ID: <20220201174335.1578352-1-jonathantanmy@google.com>
In-Reply-To: <20220129000446.99261-1-chooglen@google.com>

Glen Choo <chooglen@google.com> writes:
> Changes since v7:
> * Reword patch 5's commit message
> * In comments and Documentation/git-branch.txt, clarify how branch
>   --recurse-submodules behaves and rename a parameter to better reflect
>   this behavior
> * In t3207, always assert on error messages when using test_must_fail
> * In t3207, assert on config values using test_cmp_config. This avoids
>   the silent failures discouraged by t/README:671.
> * In patch 6, be more explicit about freeing the stack-allocated
>   variable.

I had minor comments [1] which have been addressed, so:

Reviewed-by: Jonathan Tan <jonathantanmy@google.com>

I'm OK with 6/6 being included or not being included.