From: Joel Holdsworth Date: Tue, 04 Jan 2022 12:49:12 GMT Subject: [PATCH v2 RESEND 4/5] git-p4: open temporary patch file for write only Message-ID: <20220104124913.2894-5-jholdsworth@nvidia.com> In-Reply-To: <20220104124913.2894-1-jholdsworth@nvidia.com> The patchRCSKeywords method creates a temporary file in which to store the patched output data. Previously this file was opened in "w+" mode (write and read), but the code never reads the contents of the file while open, so it only needs to be opened in "w" mode (write-only). Signed-off-by: Joel Holdsworth --- git-p4.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git-p4.py b/git-p4.py index 509feac2d8..7845210e69 100755 --- a/git-p4.py +++ b/git-p4.py @@ -1754,7 +1754,7 @@ def patchRCSKeywords(self, file, regexp): # Attempt to zap the RCS keywords in a p4 controlled file matching the given regex (handle, outFileName) = tempfile.mkstemp(dir='.') try: - with os.fdopen(handle, "w+") as outFile, open(file, "r") as inFile: + with os.fdopen(handle, "w") as outFile, open(file, "r") as inFile: for line in inFile.readlines(): outFile.write(regexp.sub(r'$\1$', line)) # Forcibly overwrite the original file -- 2.34.1