From: Mike Hommey <mh@glandium.org>
Date: Wed, 17 Nov 2021 02:52:20 GMT
Subject: Re: [PATCH v3 19/23] Makefile: correct the dependency graph of hook-list.h
Message-ID: <20211117025220.hpqn3vfhzvihoycd@glandium.org>
In-Reply-To: <patch-v3-19.23-234b4eb613c-20211116T114334Z-avarab@gmail.com>

On Tue, Nov 16, 2021 at 01:00:19PM +0100, Ævar Arnfjörð Bjarmason wrote:
> Fix an issue in my cfe853e66be (hook-list.h: add a generated list of
> hooks, like config-list.h, 2021-09-26), the builtin/help.c was
> inadvertently made to depend on hook-list.h, but it's used by
> builtin/bugreport.c.
> 
> Reported-by: Mike Hommey <mh@glandium.org>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>  Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 0a3f292bf82..bae20eb1b40 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2162,8 +2162,9 @@ git$X: git.o GIT-LDFLAGS $(BUILTIN_OBJS) $(GITLIBS)
>  
>  help.sp help.s help.o: command-list.h
>  hook.sp hook.s hook.o: hook-list.h

You can remove this line too.

Mike