From: Adam Dinwoodie Date: Thu, 04 Nov 2021 19:25:33 GMT Subject: [PATCH] t/lib-git.sh: fix ACL-related permissions failure Message-ID: <20211104192533.2520-1-adam@dinwoodie.org> SSH keys are expected to be created with very restrictive permissions, and SSH commands will fail if the permissions are not appropriate. When creating a directory for SSH keys in test scripts, attempt to clear any ACLs that might otherwise cause the private key to inherit less restrictive permissions than it requires. This change is required in particular to avoid tests relating to SSH signing failing in Cygwin. Signed-off-by: Adam Dinwoodie Helped-by: Fabian Stelzer --- t/lib-gpg.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/t/lib-gpg.sh b/t/lib-gpg.sh index f99ef3e859..1d8e5b5b7e 100644 --- a/t/lib-gpg.sh +++ b/t/lib-gpg.sh @@ -106,6 +106,7 @@ test_lazy_prereq GPGSSH ' test $? = 0 || exit 1; mkdir -p "${GNUPGHOME}" && chmod 0700 "${GNUPGHOME}" && + (setfacl -k "${GNUPGHOME}" 2>/dev/null || true) && ssh-keygen -t ed25519 -N "" -C "git ed25519 key" -f "${GPGSSH_KEY_PRIMARY}" >/dev/null && echo "\"principal with number 1\" $(cat "${GPGSSH_KEY_PRIMARY}.pub")" >> "${GPGSSH_ALLOWED_SIGNERS}" && ssh-keygen -t rsa -b 2048 -N "" -C "git rsa2048 key" -f "${GPGSSH_KEY_SECONDARY}" >/dev/null && -- 2.33.0