From: Johannes Altmanninger Date: Thu, 07 Oct 2021 18:47:16 GMT Subject: [PATCH] t/perf: do not run tests in user's $SHELL Message-ID: <20211007184716.1187677-1-aclopte@gmail.com> In-Reply-To: <20211002112640.hrn2ojndhoa2dd4c@gmail.com> The environment variable $SHELL is usually set to the user's interactive shell. We never use that shell for build and test scripts because it might not be a POSIX shell. Perf tests are run inside $SHELL via a wrapper defined in t/perf/perf-lib.sh. Use $TEST_SHELL_PATH like elsewhere. Signed-off-by: Johannes Altmanninger --- Regarding the inconsistency around $(SHELL) in Makefiles: we could do something like -SHELL_PATH ?= $(SHELL) +SHELL_PATH ?= /bin/sh +SHELL = $(SHELL_PATH) in some Makefiles. Though the upside (consistency & slightly easier to build with broken /bin/sh) seems fairly low, so I'd leave it be. t/perf/perf-lib.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/perf/perf-lib.sh b/t/perf/perf-lib.sh index f5ed092ee5..e6b59ecbf7 100644 --- a/t/perf/perf-lib.sh +++ b/t/perf/perf-lib.sh @@ -157,7 +157,7 @@ test_run_perf_ () { test_cleanup=: test_export_="test_cleanup" export test_cleanup test_export_ - "$GTIME" -f "%E %U %S" -o test_time.$i "$SHELL" -c ' + "$GTIME" -f "%E %U %S" -o test_time.$i "$TEST_SHELL_PATH" -c ' . '"$TEST_DIRECTORY"/test-lib-functions.sh' test_export () { test_export_="$test_export_ $*" -- 2.33.0.rc2.dirty