From: Mike Hommey Date: Tue, 05 Oct 2021 08:35:00 GMT Subject: Re: [PATCH] Use mingw.h declarations for gmtime_r/localtime_r on msys2 Message-ID: <20211005083500.jd7byba4abupdub5@glandium.org> In-Reply-To: On Tue, Oct 05, 2021 at 12:12:12AM -0700, Carlo Arenas wrote: > On Mon, Oct 4, 2021 at 11:57 PM Mike Hommey wrote: > > A possible alternative fix would be to e.g. add `#define _POSIX_C_SOURCE > > 200112L` to git-compat-util.h and add `ifndef __MINGW64_VERSION_MAJOR` > > around the definitions of `gmtime_r` and `localtime_r` in > > compat/mingw.c, since, after all, they are available there. > > something like that was merged to "main"[1] a few months ago, would > that work for you? This seems very close to what I was suggesting, so I would guess so :) I'm wondering if there's a reason not to set _POSIX_C_SOURCE everywhere, along the other _*_SOURCE's. Mike