From: Kaartic Sivaraam Date: Mon, 21 Jun 2021 19:08:36 GMT Subject: [PATCH 1/2] submodule--helper: remove an unreachable call to usage_with_options Message-ID: <20210621190837.9487-2-kaartic.sivaraam@gmail.com> In-Reply-To: <20210621190837.9487-1-kaartic.sivaraam@gmail.com> The code path in question calls `error` in a particular case. But, `error` never returns as it exits directly. This makes the call to `usage_with_options` that follows the `error` call unreachable. So, remove the unreachable `usage_with_options` call. Signed-off-by: Kaartic Sivaraam --- builtin/submodule--helper.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index ae6174ab05..c9aa838083 100644 --- a/builtin/submodule--helper.c +++ b/builtin/submodule--helper.c @@ -1637,8 +1637,6 @@ static int module_deinit(int argc, const char **argv, const char *prefix) if (all && argc) { error("pathspec and --all are incompatible"); - usage_with_options(git_submodule_helper_usage, - module_deinit_options); } if (!argc && !all) -- 2.32.0.9.g81a5432dce.dirty