From: Felipe Contreras Date: Mon, 31 May 2021 19:51:13 GMT Subject: [PATCH v2 02/13] push: return immediately in trivial switch case Message-ID: <20210531195124.218325-3-felipe.contreras@gmail.com> In-Reply-To: <20210531195124.218325-1-felipe.contreras@gmail.com> There's no need to break when nothing else will be executed. Will help next patches. Signed-off-by: Felipe Contreras --- builtin/push.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/builtin/push.c b/builtin/push.c index e3e792c69c..0aa1d0f07d 100644 --- a/builtin/push.c +++ b/builtin/push.c @@ -257,25 +257,25 @@ static void setup_default_push_refspecs(struct remote *remote) default: case PUSH_DEFAULT_MATCHING: refspec_append(&rs, ":"); - break; + return; case PUSH_DEFAULT_UNSPECIFIED: case PUSH_DEFAULT_SIMPLE: setup_push_simple(remote, branch, same_remote); - break; + return; case PUSH_DEFAULT_UPSTREAM: setup_push_upstream(remote, branch, same_remote); - break; + return; case PUSH_DEFAULT_CURRENT: setup_push_current(remote, branch); - break; + return; case PUSH_DEFAULT_NOTHING: die(_("You didn't specify any refspecs to push, and " "push.default is \"nothing\".")); - break; + return; } } -- 2.32.0.rc0