From: Felipe Contreras Date: Fri, 28 May 2021 20:10:11 GMT Subject: [PATCH 08/11] push: fix Yoda condition Message-ID: <20210528201014.2175179-9-felipe.contreras@gmail.com> In-Reply-To: <20210528201014.2175179-1-felipe.contreras@gmail.com> We want to check if remote is the same as the branch remote, not the other way around. Signed-off-by: Felipe Contreras --- builtin/push.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/push.c b/builtin/push.c index f008cd624f..2dda1724cc 100644 --- a/builtin/push.c +++ b/builtin/push.c @@ -237,7 +237,7 @@ static void setup_push_simple(struct remote *remote, struct branch *branch, int static int is_workflow_triangular(struct remote *remote) { - return remote_get(NULL) != remote; + return remote != remote_get(NULL); } static void setup_default_push_refspecs(struct remote *remote) -- 2.32.0.rc0