From: Mike Hommey <mh@glandium.org>
Date: Tue, 16 Mar 2021 09:10:26 GMT
Subject: Re: [ANNOUNCE] Git v2.31.0
Message-ID: <20210316091026.wta7wpxdyr75xo6x@glandium.org>
In-Reply-To: <875z1rfpmr.fsf@evledraar.gmail.com>

On Tue, Mar 16, 2021 at 09:51:08AM +0100, Ævar Arnfjörð Bjarmason wrote:
> 
> On Tue, Mar 16 2021, Mike Hommey wrote:
> 
> > On Mon, Mar 15, 2021 at 12:30:15PM -0700, Junio C Hamano wrote:
> >>  * Two new ways to feed configuration variable-value pairs via
> >>    environment variables have been introduced, and the way
> >>    GIT_CONFIG_PARAMETERS encodes variable/value pairs has been tweaked
> >>    to make it more robust.
> >
> > For the record, this is backwards incompatible with git-programs in
> > $PATH that were expecting the old format (e.g. git-cinnabar releases
> > using an older version of libgit.a).
> 
> What isn't noted there is that we're still parsing the old format in
> some cases, see f9dbb64fad (config: parse more robust format in
> GIT_CONFIG_PARAMETERS, 2021-01-12).
> 
> But I suspect you mean that you have your own parser that expects the
> old format only, I didn't find which way it was by grepping
> git-cinnabar's sources.

git-cinnabar is using git's libgit.a, so when using a pre-compiled
version built against git < 2.31.0, it fails to parse
GIT_CONFIG_PARAMETERS when used with git 2.31.0.
There's not much I can do apart from releasing a new version.

Mike